Skip to content

Fix bug introduced by #143 by lowercasing key in getHeader #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2020
Merged

Fix bug introduced by #143 by lowercasing key in getHeader #183

merged 1 commit into from
Dec 5, 2020

Conversation

andyexeter
Copy link
Contributor

As discussed, #143 lowercases all headers in CurlResponse. This is a breaking change which stops the following from working:

php-shopify/lib/CurlRequest.php

Line 163 in a233b8d

$limitHeader = explode('/', $response->getHeader('X-Shopify-Shop-Api-Call-Limit'), 2);

This PR lowercases the given key in the CurlResponse::getHeader method before checking if it is set.

@andyexeter andyexeter mentioned this pull request Oct 12, 2020
Merged
@andyexeter
Copy link
Contributor Author

@tareqtms could you look at merging this?

@tareqtms tareqtms merged commit d06cb86 into phpclassic:master Dec 5, 2020
@andyexeter andyexeter mentioned this pull request Dec 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyexeter @tareqtms